Discussion:
[PATCH Version 3 0/1] NFSv4.1: Fix an NFSv4.1 state renewal regression
a***@public.gmane.org
2014-09-29 16:29:04 UTC
Permalink
From: Andy Adamson <andros-HgOvQuBEEgTQT0dZR+***@public.gmane.org>

Version 3 responds to a review request by Trond:

The problem here isn't that we're failing to send a SEQUENCE in a
situation where we're not required to do so by the spec. The problem
is that we're failing to rearm renewd when we skip that SEQUENCE call.

Instead of removing them, could you rather please modify the above
lines to return an error, and then have nfs4_renew_state() respond by
calling nfs4_schedule_state_renewal(), instead of just skipping it as
we do today. In fact, AFAICS we want to do the same when the renew
call fails due to ENOMEM (but not when it returns EIO, since that
signals that the nfs_client is in the process of shutting down).

Andy Adamson (1):
NFSv4.1: Fix an NFSv4.1 state renewal regression

fs/nfs/nfs4proc.c | 2 +-
fs/nfs/nfs4renewd.c | 14 ++++++++++++--
2 files changed, 13 insertions(+), 3 deletions(-)
--
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-***@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Loading...